Updating a custom dropdown field in quotes using doble click in the display screen appear a meessage currency.php line 100

ariajf00 · 24 March 2022 00:26

I created a custom field type dropdown in quotes to allow users include a new status value for records, when the field is updated using edit function everything works well; but if using display screen make a double clik in thje check symbol field and change the value appear a message:

Warning : A non-numeric value encountered in /var/www/vhosts/3dproductos.com.co/crm.lamarcgroup.com/modules/Currencies/Currency.php on line 100

even if you dont select any field of the list appear the mesage

ariajf00 · 6 April 2022 12:59

Anybody has a feedback, this issue still appear when I try to update dropdowns from display screen.

pgr · 6 April 2022 15:04

If you’re value is a dropdown, it probably presents as a string.

If it is a string, it has to be convertible to a PHP float.

So that probably breaks if your language settings use commas instead of dots.

See

github.com

salesagility/SuiteCRM/blob/master/modules/Currencies/Currency.php#L116

      
        
             * convertFromCollar
             * This method accepts a US Dollar amount and returns a currency amount
             * with the conversion rate applied to it.
             *
             * @param $amount string|float The currency amount in US Dollars
             * @param $precision int The rounding precision scale
             * @return float currency value from US Dollar conversion
             */
            public function convertFromDollar($amount, $precision = 6)
            {
                $amount = is_string($amount) ? (float)$amount : $amount;
            
            
    return round(($amount * $this->conversion_rate), $precision);
            }
            
            
/**
             * getDefaultCurrencyName
             *
             * Returns the default currency name as defined in application
             * @return String value of default currency name
             */

pgr · 6 April 2022 15:38

I would try adding this solution there:

It seems to work with all kinds of numbers and regional notations.