Type 'ExecutionResult' is not generic

bkm · 6 January 2022 12:42

When Setting Up a Front-End Extension Module step 7 Build Core an error occur when executing

yarn run build:core or yarn run build-dev:core

the following is the output after executing the commands

Building entry point ‘core’

Compiling with Angular sources in Ivy full compilation mode.
node_modules/@apollo/client/utilities/common/errorHandling.d.ts:2:55 - error TS2315: Type ‘ExecutionResult’ is not generic.

2 export declare function graphQLResultHasError(result: ExecutionResult): boolean;
~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@apollo/client/link/core/types.d.ts:19:134 - error TS2315: Type ‘ExecutionResult’ is not generic.

19 export interface FetchResult<TData = Record<string, any>, TContext = Record<string, any>, TExtensions = Record<string, any>> extends ExecutionResult<TData, TExtensions> {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error Command failed with exit code 1.

clemente.raposo · 7 January 2022 13:16

Hi @bkm,

Thank you for the feedback.

There is a know issue in apollo that matches the problem you’ve described. Though it is just for more recent version:

github.com/apollographql/apollo-client

Typescript build error "Generic type 'ExecutionResult<TData>' requires between 0 and 1 type arguments" with graphql@14

opened 02:17AM - 09 Dec 21 UTC

leereamsnyder

**Intended outcome:** I am hitting this and just saw this [mentioned in a comment](https://github.com/apollographql/apollo-client/issues/9034#issuecomment-988355563) on another issue #9034 but I think this is a different issue. After updating to the latest @apollo/client packages and following the migration guide (I was coming from `apollo-client@2.6.4`), my Typescript build process should still work with the same supported version of GraphQL. Judging from @apollo/client's peer dependencies, that should be ^14, ^15, or ^16.  **Actual outcome:** `tsc` command fails with a Typescript error. Doing `tsc --check-types` gives the following error: ``` ../../node_modules/@apollo/client/link/core/types.d.ts:19:134 - error TS2707: Generic type 'ExecutionResult<TData>' requires between 0 and 1 type arguments. 19 export interface FetchResult<TData = Record<string, any>, TContext = Record<string, any>, TExtensions = Record<string, any>> extends ExecutionResult<TData, TExtensions> { ``` Going into that `@apollo/client/link/core/types.d.ts` types declaration file, I see this error: <img width="951" alt="Screen Shot 2021-12-08 at 9 03 55 PM" src="https://user-images.githubusercontent.com/870668/145321297-1f926da9-1033-411d-b792-ca3009bdcbfb.png"> And ExecutionResult appears to be coming from 'graphql', so I'm assuming that's where the type mismash is happening.  **How to reproduce the issue:**  You should be able to create a typescript project with these packages: - typescript@4.1.3 - @apollo/client@3.5.6 (also present with 3.5.5) - graphql@14.7.0 and `tsc` should throw that error. **Versions**  ``` System: OS: macOS 11.6.1 Binaries: Node: 12.22.7 - /usr/local/bin/node Yarn: 1.22.10 - /usr/local/bin/yarn npm: 6.14.15 - /usr/local/bin/npm Browsers: Chrome: 96.0.4664.93 Firefox: 95.0 Safari: 15.1 ``` Thank you in advance. I wish Typescript gave literally any more information, but that's what I've got. :(

Just a few questions to try and understand the problem.

1. What version of apollo are you using?

You can run yarn list --pattern @apollo/client

You should get something like:

... $ yarn list --pattern @apollo/client
yarn list v1.22.10
└─ @apollo/client@3.4.11
Done in 0.93s.

2. Did you run `yarn upgrade`?

yarn install should use the version specified in the yarn.lock file which is:

"@apollo/client@^3.0.0-beta.23", "@apollo/client@^3.3.7":
  version "3.4.11"

3. Version check

The following are the versions I have, are any of yours different?

To get this info I’ve run ng --version

$ ng --version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 12.1.0
Node: 14.18.2
Package Manager: yarn 1.22.10
OS: linux x64

Angular: 12.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.14
@angular-devkit/build-angular   12.2.14
@angular-devkit/core            12.1.0
@angular-devkit/schematics      12.1.0
@angular/cdk                    11.2.13
@schematics/angular             12.1.0
ng-packagr                      12.2.6
rxjs                            6.6.7
typescript                      4.3.5
webpack                         5.65.0

bkm · 8 January 2022 03:16

Hi @clemente.raposo ,

after running yarn install , the yarn run build-dev:core works fine but when yarn run build-dev:shell the apollo/client still errors

Error: core/app/shell/src/app/app.module.ts:149:13 - error TS2322: Type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’ is not assignable to type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’.

149 link: logoutLink.concat(http),
~~~~

node_modules/@apollo/client/core/ApolloClient.d.ts:19:5
19 link?: ApolloLink;
~~~~
The expected type comes from property ‘link’ which is declared here on type ‘ApolloClientOptions’

Error: core/app/shell/src/app/app.module.ts:149:37 - error TS2345: Argument of type ‘HttpLinkHandler’ is not assignable to parameter of type ‘ApolloLink | RequestHandler’.
Type ‘HttpLinkHandler’ is not assignable to type ‘ApolloLink’.
Types of property ‘split’ are incompatible.
Type ‘(test: (op: import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").Operation) => boolean, left: import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").RequestHandler, ri…’ is not assignable to type ‘(test: (op: import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/types").Operation) => boolean, left: import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/…’.
Types of parameters ‘left’ and ‘left’ are incompatible.
Type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/types").RequestHandler’ is not assignable to type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").RequestHandler’.
Type ‘ApolloLink’ is not assignable to type ‘ApolloLink | RequestHandler’.
Type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’ is not assignable to type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’.
Types of property ‘split’ are incompatible.
Type ‘(test: (op: import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/types").Operation) => boolean, left: import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/…’ is not assignable to type ‘(test: (op: import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").Operation) => boolean, left: import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").RequestHandler, ri…’.
Types of parameters ‘left’ and ‘left’ are incompatible.
Type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/types").RequestHandler’ is not assignable to type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink | import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/types").RequestHandler’.
Type ‘ApolloLink’ is not assignable to type ‘ApolloLink | RequestHandler’.
Type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’ is not assignable to type ‘import("/home/pivotdev1/ftp/files/node_modules/@apollo/link-error/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink’.
Property ‘onError’ is protected but type ‘ApolloLink’ is not a class derived from ‘ApolloLink’.

149 link: logoutLink.concat(http),
~~~~

Error: node_modules/@apollo/client/utilities/globals/global.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable ‘DEV’.

2 const DEV: boolean | undefined;
~~~~~~~

node_modules/@apollo/link-error/node_modules/@apollo/client/utilities/globals/global.d.ts:2:11
2 const DEV: boolean | undefined;
~~~~~~~
‘DEV’ was also declared here.

Error: node_modules/@apollo/link-error/node_modules/@apollo/client/utilities/globals/global.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable ‘DEV’.

2 const DEV: boolean | undefined;
~~~~~~~

node_modules/@apollo/client/utilities/globals/global.d.ts:2:11
2 const DEV: boolean | undefined;
~~~~~~~
‘DEV’ was also declared here.

error Command failed with exit code 1.

clemente.raposo · 10 January 2022 23:28

Hi @bkm,

Thank you for the feedback. And apologies for the delay.

Could you check what version on yarn.lock please? is it the same as the one I sent on the previous post?

Could you also run ng --version and send it, please? just to double check.

web_elinet · 23 September 2022 14:19

Hi,
I also had the same problems as @bkm , now if I run the yarn run command build-dev:shell
I get the following error:

My Angular version is:

Any Idea?

Thanks

Type 'ExecutionResult' is not generic

Building entry point ‘core’

1. What version of apollo are you using?

2. Did you run yarn upgrade?

3. Version check

2. Did you run `yarn upgrade`?