Quote Line Items and line_items.js

💬 General Discussion
1

Hi Guys,

Wondering if anyone me…

I am doing some modification to the Quotes Line Item Area, removing the Fields which we do not need i.e. Discount/Tax Amount.

I have managed to remove the fields on the Details View but the Edit View has got me.

From what I can see the Edit View is driven by line_items.js but no matter what I do, the changes I put in the the line_items file is ignored.

I have even deleted the line_items.js file but the edit screen still sits there laughing at me…

I have done a quick repair and rebuild and disabled caching, and still no joy.

Please can someone tell me how to modify the Line Items Area on the Quote Edit Screen or where I am going wrong.

Regards,

Matt

2

Hi Matt Hart,

Do you have developer mode on in the admin section?

Thanks,

Will.

3

Hi Will,

Yes, I do.

Matt

4

Hi Matt,

What exactly are you editing in line_items.js. Are your permissions set as required?

Thanks,

Will.

5

Basically I’m trying to get rid of Discount and Tax Amount (service items) and put an Part Number field in

I have tried removing and adding Items to the insertServiceHeader function but it doesn’t seem to make any difference.

All files on the server have 777 so permissions are not the issue.

6

Hi Matt,

You will not only need to edit the insertServiceHeader but insertServiceLine and many other areas of line_items.js to get your desired result.

Thanks,

Will.

7

I have the same issue: I have tried to change how the total is calculated, but my changes do not seem to have any effect. I have even tried to set some of the values to a constant just so that I could actually see a change - but nothing happens.

8

I have mentioned before I deleted the line_items.js and it still worked somehow.

Anymore idea Will?

Regards,

Matt

9

Hi Will,

Can you just check my thinking/Do is correct.

So i am trying to remove the discount field in the edit view of quotes (line Item - Services)

So in line_items.js located in /htdocs/modules/AOS_Products_Quotes

function insertServiceHeader

Remove

var c=x.insertCell(2);
    c.style.color="rgb(68,68,68)";
    c.innerHTML=SUGAR.language.get(module_sugar_grp1, 'LBL_SERVICE_DISCOUNT');

function insertServiceLine

Remove

var a2 = x.insertCell(2);
    a2.innerHTML = "<input type='text' style='text-align: right; width:90px;' name='service_product_discount[" + servln + "]' id='service_product_discount" + servln + "' size='12' maxlength='50' value='' title='' tabindex='116' onfocus='calculateLine(" + servln + ",\"service_\");' onblur='calculateLine(" + servln + ",\"service_\");'><input type='hidden' name='service_product_discount_amount[" + servln + "]' id='service_product_discount_amount" + servln + "' value=''  />"
        + "<select tabindex='116' name='service_discount[" + servln + "]' id='service_discount" + servln + "' onchange='calculateLine(" + servln + ",\"service_\");'>" + discount_hidden + "</select>";

With these lines removed from this file it should have stopped the discount field from appearing?

I’m i missing something really obvious?

Sorry to be a pain.

Regards,

Matt

10

Hi Matt,

This is a caching issue. Have you cleared the browser cache? Do you have a configuration on your server which could be cause caching issues, or are you working locally?

Thanks,

Will.

1 Like
11

Hi Will,

You are correct again.

I have just manually delete the cache from SuiteCRM and I can now see my changes :slight_smile:

Thanks for your help.

Regards

Matt

12

Will, you are a legend!

Many Thanks!

13

hi guys,

i am also did same thing,

i remove the discount fields in line items(line_items.js),

but calculation not working in line items it will affected Tax Amount Fields,

if enter list amount 150.00 total,subtotal,Grandtotal all are same amount.

how to remove discount fields without affected any Calculation.

pls help

by
sam

14

Hi, I am new at using CRM and I want to add new field at (product line) and I don’t know how to do it using java script … Could you please help me with the code and where to put it … thanks a lot