Operator [Is null] is not available in Report module?

yekcid · 3 January 2024 03:27

Hi everyone,

Just want to confirm that the operator [Is null] is not available in Report Module, because I found it in workflow and available for other modules. Only missing in Report module.

Is this normal?

suiteCRM Version 7.13.1
Sugar Version 6.5.25 (Build 344)
Deployed on Windows 10 Platforms

pgr · 3 January 2024 10:04

I see some signs of related things on Github

github.com/salesagility/SuiteCRM

Fix #9939 - Consistent Null/Empty handling on Reports and Workflows

salesagility:hotfix-7.13.x ← simonr44:fix/workflow_reports_consistent_null_empty

opened 05:21PM - 09 Feb 23 UTC

simonr44

+23 -0

## Description When comparing empty and null strings, the current handling of t…his is inconsistent between Reports and AOW_Workflows Reports: - Checks if a value is empty or null during an "equal to" empty string value. - Checks if a value is empty during a "not equal to" empty string value. Workflows: - Checks if a value is empty during an "equal to" empty string value. - Checks if a value is empty during a "not equal to" empty string value. This change will: - Check for null or empty strings on an "equal to" - Check for not null or empty strings on an "not equal to" As null will now be considered empty where it was not previously, this may lead to different (hopefully more accurate?) report / workflow results depending upon the data set. Still something to consider. Null values can still be checked with the null, not null condition parameters and are unaffected by this change. ## Motivation and Context Records returned between these two modules are different with the same conditions ## How To Test This 1. Create a report which checks against a null-able field with empty values 2. Behaviour will be consistent between "equal to" and "not equal to" across the two modules discussed. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Final checklist - [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/). - [ ] My change requires a change to the documentation. - [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.

and this one is probably your solution, but it seems it got derailed, and you might have some trouble extracting the relevant commits from that PR because it’s showing unrelated changes:

github.com/salesagility/SuiteCRM

add not contains and is not null conditions operator to workflow and reports

salesagility:develop ← oc666:not_contains_condition

opened 09:21PM - 23 Apr 18 UTC

oc666

+7872 -338579

## Description * Add not contains condition to workflow and reports. * A…dd is not null condition to workflow. ## Motivation and Context There is condition of contains of varchar. ## How To Test This add new workflow or report with condition of not contains. ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Final checklist - [X] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/). - [X] My change requires a change to the documentation. - [X] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.