Old Bug Still Present in SuiteCRM 8.8.0

👨‍💻 Development Help
1

Hello Everyone,

Here to say that in my Clean Install of SuiteCRM 8.8.0 this bug is still present:

Wish you all a Good Day :smiley:

2

Is there an Issue open for this on Github? And maybe even a Pull Request with the solution by @p.konetskiy ?

Because it won’t get fixed without that done…

3

Maybe related:

4

Yes its related.

Believe like @pgr said, it needs to be reviews by 2 accounts to get pulled.

I already reviewed so anyone else needs to review.

1 Like
5

The second review needs to be from one of the maintainers, I am afraid. That’s where the bottleneck is…

2 Likes
6

Is it possible to challenge this policy?
Maybe make it either 4 community reviews or 1 community + 1 maintainer or similar?

1 Like
7

Hi Bastian, i think this is the best approach actually.

8

Any new policy that would prevent the PR’s from getting stalled eternally would be an improvement on the current situation.

But you’ll have to convince the maintainers, not me…

9

Maintainers are unable to merge without proper review. It is critical to thoroughly assess all pull requests (PRs) and potential security risks before merging any code changes.

I think that if the team decides to grant additional authority to community reviewers, these reviewers must sign a legal agreement to ensure adherence to all established rules and guidelines.

Watch this interesting video about Andres Freund; how he saved the internet. :partying_face: :star_struck:

1 Like
10

I read the news once it went public and it really was my first thought after thinking throught this Subject (Also Love Fern videos regarding any Tech Involved), a legal agreement would be a great Security Addon to Reviewers but i am not sure how breachable that can be, Forging Signature, Faking the Legal Agreement, etc.Having a Maintainer review before pulling is the Solution but there it is, Maintainers not always have time to Review all code.I really would like to know a Maintainer thoughts regarding this Subject.

11

Thanks for the feedback everyone,

At the moment, we have a large backlog of Pull Requests(PRs) and it still very important that all PRs are assessed by our experienced engineers. Really we need those who work very closely with the code, to try to ensure there’s not going to be any new issues or unexpected things happening from merging PRs. This will likely get easier as we transition more to SuiteCRM 8.

One thing you’ll notice we are increasingly doing is grading the perceived complexity of PRs and this is done so it’s easier for us to see which ones will be easier to merge, so we can prioritise and merge more that way.

The way that you can support us best prioritise issues and PRs important to you, is to make use of Issue and PR voting. As yet, this is not being greatly adopted and we will be working to get the word out more about it. But the more it’s used the more effective it will become and the faster we can merge the most important pull requests for everyone.

Other ways you can contribute, is by by assessing pull request especially if you have feedback on the code, to help it get fixes done quicker, the main review will still be done by the SuiteCRM team.

Or if you have tested it you can post if it works for you. The second review will come from our QA team once has been integrated with all the other PRs and your feedback will help them

So if we can all vote on this PR we can make it the first and hopefully the first of many to be merged based on community voting. Otherwise, we we would love to know what you think of voting on PRs and issues or how we can make this even better.

2 Likes