How to stop the depreciated mPDF module from being called?

Hopeless · 12 March 2024 12:38

SuiteCRM 7.14.3
PHP 8.1
Ubuntu 22.04

Hello community,
the mPDF is spamming errors due to no longer supported syntax and I am looking for a safe way to disable it.

Edit: I seem to have tracked down the issue. Despite no longer existing in the PDF modules list, the mPDF module was still being called as PDF handler. Selecting the TCPDF Engine again and saving appears to have stopped that behavior.

pgr · 12 March 2024 13:26

Please post the errors, the exact text.

Hopeless · 12 March 2024 13:30

Apache2 log:

[Tue Mar 12 13:13:13.795746 2024] [proxy_fcgi:error] [pid 40164] [client 10.49.1.250:19643] AH01071: Got error 'PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /var/www/CRM/modules/AOS_PDF_Templates/PDF_Lib/mpdf.php on line 2138', referer: https://crm.blah.com/index.php?action=ajaxui

In the Browser I get Error 500.

pgr · 12 March 2024 13:34

You shouldn’t need to remove it. It’s deprecated, and the code should not be called from anywhere. The question is, which code is calling that?

If you can get a stack trace on the error, we can find out.

Hopeless · 12 March 2024 13:44

Which log do you need? I haven’t seen errors related to this module in any other log, just the error 500 in the browser if I try to print a PDF from the Accounts or Invoices modules.

pgr · 12 March 2024 13:48

I don’t need a log, I need a stack trace. My experience in these forums is that either you are a developer and understand what a stack trace is, or you won’t be able to get one and this conversation won’t go anywhere. Sorry. I made this PR to avoid all this wasted time in the forums:

github.com/salesagility/SuiteCRM

Improved logging, richer stack traces - 7.14

salesagility:hotfix ← pgorod:ImprovedLogging7.14

opened 10:20PM - 26 Jan 24 UTC

pgorod

+412 -50

> NOTE: this is the redone version of a much older PR, #8640 which has a bunch o…f comments and code reviews, in case any one wants to check for historical reasons ## Description, Motivation and Context Adds some `config_override.php` options to get more information in the logs, specifically: - ability to ask for richer information regarding a single error message, making it easier to focus on a specific problem - ability to get more highly technical information without being a technical user (useful for Forums troubleshooting and gathering info from clients) - get IDE-level stack traces, with both argument names **and values** ## Documentation preview https://pedro--suitedocs.netlify.app/developer/logging/#_advanced_logging_configuration ## How To Test This Please read the documentation linked above, there are many options. An important part of the testing is confirming that **nothing changes** until we start putting options in `config_override.php`. This will make me more confident about putting the code out there :-) For a simple run, you can test this by adding entries in your `config_override.php` such as these (all explained in the Docs page): ```php $sugar_config['show_log_trace'] = 'One2MBeanRelationship'; // use a boolean true for all; or a string as filter $sugar_config['show_log_trace_with_eol'] = true; $sugar_config['show_log_trace_overview'] = true; $sugar_config['show_log_trace_trim'] = 500; $sugar_config['show_log_trace_source'] = 1; ``` ## Answers to some valid concerns 1. This is **backwards compatible** because it does not assume any config values to be there, always uses sensible defaults, and respects the previous meaning of `$sugar_config['show_log_trace']`. 1. This code is complex, and some bug can have slipped by, but **it only runs in the cases where you select log traces**, so it's easy to turn off, and shouldn't affect production systems. 1. Some of this code impacts **performance** (lots of string operations, more file activity) but it's always opt-in: the impact only occurs when you configure it to happen. 1. This is accompanied with a **warning** in Documentation: using log traces with argument values might leave sensitive information in the system logs. Use it only temporarily for troubleshooting purposes; obfuscate the information before posting it online; double-check that your logs are only accessible to admins; delete the logs when finished troubleshooting. ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Final checklist - [X] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/). - [X] My change requires a change to the documentation. - [X] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.

but it’s been 4 years and it hasn’t been merged. I guess my time here is not considered valuable.

sorry

Hopeless · 12 March 2024 14:32

Mate, that’s kind of rude. Just say that you want the suitecrm log with advanced logging. This isn’t a daytime drama.

pgr · 12 March 2024 14:54

Sorry, didn’t mean to come off as rude, and definitely not to you - I am a bit mad, though not at you, and I guess that possibly transpired in my reply. My apologies.

This was just yesterday. I have 10 replies there, and I did not get my stack trace. This often happens to me here in these forums. I don’t blame people - this should really be easier than it is.

cherub-chum · 13 March 2024 08:01

Is your 7.14.3 instance upgraded from lower versions? Did you faced same issue on a fresh install.

Hopeless · 13 March 2024 08:48

This was definitely an update issue after going from 7.3 to 7.4 and changing the PHP version from 8.0.50 to 8.1 to maintain compatibility.

This installation was upgraded multiple times over the years. I have tracked the issue down to the update that removed mPDF from the dropdown selection without activating an alternative PDF handler. Unfortunately I don’t have the resources to mount older backups for a closer analysis right now as our infrastructure is at maximum provisioning.

DJuser · 17 March 2024 00:38

@pgr that logging code improvement would be very helpful for the community. Great work! Let’s hope the Devs do include it soon.