Error calculating Grand Total

techuser1 · 29 December 2021 07:47

Dear all,
We’re running SuiteCRM since version 7.9.x and we upgraded it two years ago to version 7.10.11.
Only recently we start to create invoices and quotes, so we detected that, while playing with Products and Services, there is an error calculating the Grand Total.

Let’s say that we create a product and we assign the value of $1’000.
While creating the invoice, the contract or the quote, we select the product and we give a discount, either in amount or in percentage, let’s say 10% or $100, but the result is that, instead of being calculated as $900, it is calculated as $1’100: the amount of the discount is added on top, instead of being removed from the total.
We also tried to put as the amounts as negative (-100, or -10%), but the result doesn’t change.

Because we are interested in this function, we upgraded to the latest version of the series 7.10, but the problem was not fixed, so we upgraded to the latest 7.12.x, but nothing has changed.

PS: We need to mention that we tried the online demo version 8, and it’s working as it should.

Could you please support?
Thanks

samus-aran · 29 December 2021 11:54

Hmmm, Can you try out the latest 7.12.x demo (here: https://demo.suiteondemand.com) and let us know if it too works there.

Are you able to test with using your denominator of choice in case this may be part of it the issue.

Are you getting any browser console errors on the Invoice edit view?

techuser1 · 29 December 2021 12:32

Hello,
thanks for your hint.
First of all, your demo is the same version we are currently running: I created a product “myproduct” for the value of 1’000 USD.
I then created a new invoice I loaded myproduct and I applied 10% discount, and actually in the line “Discount” I can see -100 (this is correct).

This is not happening in our system, how should we debug? Apparently we don’t have any error at all…

samus-aran · 29 December 2021 12:43

Ok, interestingly there are no errors. Just to confirm that when open up the browser console log (this is a nice wee reference to explain how to via different browsers https://support.happyfox.com/kb/article/882-accessing-the-browser-console-and-network-logs/) that nothing looks like a warning or error.

Do you have any customisations that we should know about?

techuser1 · 29 December 2021 12:55

Hello Samus-Aran, thanks again for your reply.

I just realized what’s the error, and actually this is something that should be fixed.

In my example I was generic and I was speaking about USD, while actually we are in Switzerland and we use Swiss Francs (ISO → CHF).

The currency symbol for the CHF, as for the USD the symbol is the $ and for the EURO the symbol is the €, for the CHF is the ’ - ’ . This means that the system is just attaching in front of the amounts the symbol of the currency, and for the case of a Discount (that is negative) is actually writing:

’ - ’ (as the CHF currency) ’ - ’ (as the negative sign) $discount_amount.

The double “dash” makes the discount becoming positive, because probably is missing a separator or some kind of escaping while handling the currency symbol.

In fact, if we change the currency to EUR or to USD, the error disappear (both their symbols don’t have any mathematical sense) and the Discount is correctly managed as a “negative” amount.

Is it anything that could be corrected in future releases?

Thanks!

PS: We just fixed writing CHF as symbol for the currency, but this should be considered as a temporary fix.

samus-aran · 29 December 2021 13:24

Wow! Thank you for your thorough testing. That has certainly highlighted the problem and agreed, it should be resolved. To help us, can you raise this as a bug on our bug tracker (here: https://github.com/salesagility/SuiteCRM/issues ) and we can take it from there.

techuser1 · 29 December 2021 14:10

Hello Samus-Aran,
we opened a ticket.
Thanks again for the support and happy new year.

github.com/salesagility/SuiteCRM

Error when managing some currency symbols as Swiss Franc

opened 02:09PM - 29 Dec 21 UTC

psynd

#### Issue While dealing with the currencies, there is a lack of escape char.… Let's take two examples: - The USD is translated with the symbol $ - The Euro is translated with the symbol € In these two examples, the symbols don't have any mathematical sense. If we take the Swiss Franc (ISO -> CHF), the symbol used is the " - " (dash). While calculating quotes, contracts, invoices and so on, where a "Discount" is present, a standard " - " (minus) is added in front. A negative amount is managed as - (**$**) DiscountAmount, or - (**€**) DiscountAmount. If the currency used is the CHF, for a discount is added the "minus", the currency symbol "dash", and then the discount amount. This transforms the previous sequence into - (**-**) DiscountAmount. To have in sequence the minus and then the symbol dash, it makes - - = +, so the two negative symbols are transformed into a positive, because probably is missing a separator or some kind of escaping while handling the currency symbol, so the Discount is "added" instead of being "subtracted" to the total amount. #### Expected Behavior All currencies, except those like the Swiss Franc using the "minus" as symbol, work properly, and also a discount applied to the Swiss Franc should be considered as "negative". #### Actual Behavior Using the Swiss Franc, the Discount turns from a negative amount to a positive amount, making the final amount higher than before the discount. #### Possible Fix We modified the Swiss Franc symbol using "CHF", but this is not the standard Swiss Franc symbol. With our modification the discounts are correctly handled as negative amounts, but this cannot be a final solution. #### Steps to Reproduce 1. Add to the system the Swiss Franc as symbol 2. Create a quote, an invoice or a contract 3. be sure that the selected currency is the Swiss Franc 4. put any amount and after add a discount either in amount or percentage: the discount amount will appear as positive instead of negative. #### Context Low impact, but still present. #### Your Environment This is system independent.