Drag/resize in calendar stopped working after update

mattia_z · 4 April 2024 20:49

Hello!

I’ve upgraded our installation of SuiteCRM about 10 days ago, and only today I’ve been notified by the actual users that in the Calendar module it’s not possible to drag or resize the tasks anymore.

The upgrade was from 7.12.2 to 7.14.3, that besides this problem was quite uneventful.

The js console is not showing any special error, and I’ve verified that global_edit, global_items_draggable and global_items_resizable are true-ish in the generated web page.

Does anybody have any idea about what could be the problem?

Thank you in advance!

rsp · 4 April 2024 21:55

Did you do any custom code updates?

mattia_z · 4 April 2024 22:14

Nope, I’ve only applied the upgrade pack from Upgrade SuiteCRM - SuiteCRM (in two steps, first 7.12.14 then 7.14.3) through the upgrade wizard, and followed the couple of manual steps that were mentioned in the release notes (adding an index and re-encoding the wrong utf8 data).

mattia_z · 5 April 2024 06:55

I’ve now restored the “Calendar” module (and only that) from before the upgrade, so rollbacking it to 7.12.2), and the previous behavior came back.

While doing some tests, I found that in the new version, events that were created directly within the calendar were draggable/resizable (Calls or Meeting), whilst my problem was visible only with events coming from the Tasks module.

Could that be something that was done explicitly?

mattia_z · 15 April 2024 03:02

A fairly quick look into the changes, lead me to

github.com/salesagility/SuiteCRM

Calendar - "Edit all reccurences" & "Delete all recurrences" buttons appear even if not reccuring meeting => corrupt data / unexpected deletions

opened 10:25PM - 06 Feb 23 UTC

closed 09:11AM - 14 Apr 23 UTC

vaudoin

Type:Bug Status:Fix Proposed Priority:Important

#### Issue In some cases (see below), a meeting can be connected to a reccuring… parent whereas it should not. #### Expected Behavior 1. Open calendar 2. Click on an existing reccurring meeting => view the "Edit all reccurences" and "Delete all recurrences" buttons 3. Cancel 4. Then click on an existing **non** recurring meeting => do not see this buttons #### Actual Behavior 1. Open Calendar 2. Click on an existing reccurring meeting (let say M1) => you see the "Edit all reccurences" and "Delete all recurrences" buttons 3. Cancel 5. Click on an existing **non** reccurring meeting (let say M2) => you still see the "Edit all reccurences" and "Delete all recurrences" buttons (!) 6. If you Save this **non** recurring meeting (M2), in the database I can see the repeat_parent_id identical to the recurring one (M1). Actually, I guess that the hidden input field repeat_parent_id is not cleared while opening another non recurring meeting. If on M1 you click on "Delete all recurences", that could cause unexpected deletion of M2 (not part of the reccurence)! #### Context I found out this issue as I discovered massive unexpected deleted meetings. As we are using a lot of reccuring meetings, this issue can happen quite often. Indeed It could corrupt the meetings data. To find out the corrupted meetings which should not be connected to a recurring parent: ``` select * from meetings m where repeat_parent_id is not null and repeat_parent_id <> '' and (m.repeat_type is null or m.repeat_type = '') ``` #### Your Environment * SuiteCRM Version used: 7.12. 4 (but I tryied on SuiteCRM 8 demo and it is still the same behaviour) * Browser name and version: tryied on Firefox / Chrome last versions. * Environment name and version (e.g. MySQL, PHP 7): MySQL / PHP 7

and the related commits to the several branches. Indeed reverting Cal.js to the previous version before that commit just brings back the previous behavior.

I suspect I’ll need to now figure out if my users were relaying on what was effectively an unexpected behavior (at least reading the bug report), or if the fix broke a real use case…

rsp · 15 April 2024 13:34

oh so that following fix worked for you?

github.com/salesagility/SuiteCRM

Fix #9930 - Recurrent calendar items

salesagility:hotfix ← QuickCRM:hotfix

opened 08:11AM - 16 Feb 23 UTC

QuickCRM

+3 -1

## Description Fix #9930 ## Motivation and Context If, after opening a recurrent meeting in the calendar, subsequent non recurrent meetings opened and saved in the calendar are wrongly attached to the previous repeat_parent_id and the buttons allowing edition or deletion of recurrent meetings are displayed ## How To Test This ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Final checklist - [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/). - [ ] My change requires a change to the documentation. - [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.

mattia_z · 15 April 2024 20:05

No, it’s the opposite!

That “fix” broke it for me, reverting the change done there makes it work again.