Dealing with signature and templates

isaacmarco · 13 February 2022 21:16

I need help in order to solve this old issue https://github.com/salesagility/SuiteCRM/issues/4075

Signature is deleted when users load an email template and there is no way to reload it. This has been broken for many time, may be from SuiteCRM 7.9.

I’m not php or java expert and I need some help.

I think the code to patch is in:

github.com

salesagility/SuiteCRM/blob/hotfix/modules/Emails/include/ComposeView/EmailsComposeView.js#L1331

    
      
                  $(this).parent().find('[name="' + inputName + '"]').attr('name', removeName);
                  if (isDraft) {
                    removeDraftAttachmentInput.val(removeDraftAttachmentInput.val() + '::' + id);
                  }
                });
                fileGroupContainer.append(removeAttachment);
              }
            }
          };
          
          
$.fn.EmailsComposeView.onTemplateSelect = function (args) {
          
          
  var confirmed = function (args) {
              var args = JSON.parse(args);
              var form = $('[name="' + args.form_name + '"]');
              $.post('index.php?entryPoint=emailTemplateData', {
                emailTemplateId: args.name_to_value_array.emails_email_templates_idb
              }, function (jsonResponse) {
                var response = JSON.parse(jsonResponse);
                $.fn.EmailsComposeView.loadAttachmentDataFromAjaxResponse(response);
                $(form).find('[name="name"]').val(response.data.subject);

Maybe an easy fix would be to force a signature refresh after the template is loaded but I don’t know how to deal with this.

Thank you.

isaacmarco · 24 February 2022 12:16

It was hard for me but I sent this PR https://github.com/salesagility/SuiteCRM/pull/9518

c.panton · 24 February 2022 14:57

Hi @isaacmarco ,

Thank you for raising this pull request on GitHub. A member of the team will assess this as soon as possible.