Creating default object from empty value using php 7.4.22

alessandro · 31 August 2021 10:40

When using Studio and click on fields, it returns this error:
Creating default object from empty value in /var/www/suitecrm/modules/ModuleBuilder/views/view.modulefields.php on line 109
This happens with php 7.4.22 and SuiteCRM 7.11.20
Not happens with 7.3
Can you help us ? I would like to use 7.4 and no more 7.3
Thanks

zillion_dev · 8 October 2021 06:00

did you got any solution for this error?
I have same error after transfer SuiteCRM from local machine to server.

samus-aran · 8 October 2021 12:13

Hey folk, are you able to provide any php error logs to narrow this down? It would be much appreciated.

alessandro · 8 October 2021 12:39

This is my log error.
[Fri Oct 08 14:26:58.954210 2021] [php7:warn] [pid 24142] [client 10.0.3.2:32972] PHP Warning: Creating default object from empty value in /var/www/suitecrm/modules/ModuleBuilder/views/view.modulefields.php on line 109, referer: https://crmtest.pqe.eu/index.php?module=ModuleBuilder&action=index&type=studio

samus-aran · 8 October 2021 12:54

Super thanks.

Ok, we do have a step forward to a degree. These are warnings, if you so incline you can set your PHP to ignore them. I think in PHP 7.4 the default is to show all errors including warnings.
That would be the quick win.

However, the route of the issue looks like there is an object that isn’t being declared prior to line 109. Now I’m not sure yet which part that would be yet, but it could be either

$studioClass

or

$studioClass->mbvardefs

So there still will need to be a wee investigation on what it is, PR created and tested BUT as I said you can jump over this y setting your php.ini to ignore all Warnings.

github.com

salesagility/SuiteCRM/blob/master/modules/ModuleBuilder/views/view.modulefields.php#L109

    
      
                  } else {
                      $f[$mod_strings['LBL_HDEFAULT']][$def['name']] = $def;
                      $def['custom'] = false;
                  }
          
          
        $def['type'] = isset($fieldTypes[$def['type']]) ? $fieldTypes[$def['type']] : ucfirst($def['type']);
                  $fieldsData[] = $def;
                  $customFieldsData[$def['name']] = $def['custom'];
              }
          }
          $studioClass->mbvardefs->vardefs['fields'] = $f;
          $smarty->assign('module', $studioClass);
          
          
$package = new stdClass;
          $package->name = '';
          $smarty->assign('package', $package);
          global $current_user;
          $sortPreferences = $current_user->getPreference('fieldsTableColumn', 'ModuleBuilder');
          $smarty->assign('sortPreferences', $sortPreferences);
          $smarty->assign('fieldsData', getJSONobj()->encode($fieldsData));
          $smarty->assign('customFieldsData', getJSONobj()->encode($customFieldsData));

alessandro · 8 October 2021 13:13

Hi,
I cannot ignore removing warnings because I can’t work with fields. This attached is how it is when I’m clicking on Fields .

samus-aran · 8 October 2021 13:30

Hi @alessandro

When I mean removing the warnings I am referring to updating your php.ini on the server that your SuiteCRM instance sits on. Have a quick read on how to do this if you were on a linux server.

Now, if possible, you could help me out with testing some code to actually resolve this issue rather than switching off your warnings via PHP.

If you are able to edit the file modules/ModuleBuilder/views/view.modulefields.php with adding in the following code that would be super. Obviously, try this on a local or test instance, not production!

github.com/salesagility/SuiteCRM

Declaring object within StudioClass to remove Strict Warnings

salesagility:hotfix ← samus-aran:samus-aran-patch-2

opened 01:28PM - 08 Oct 21 UTC

samus-aran

+3 -0

https://community.suitecrm.com/t/creating-default-object-from-empty-value-usin…g-php-7-4-22/81710 When using PHP 7.4 + it appears that when PHP WARNINGS are enabled users are unable to created fields in Module Builder / Studio. **_Creating default object from empty value in /var/www/suitecrm/modules/ModuleBuilder/views/view.modulefields.php on line 109_** https://community.suitecrm.com/uploads/default/optimized/2X/0/05bd70091fc64f6b7e5ef52286a67d64ab587abd_2_690x261.png This is due to line: https://github.com/salesagility/SuiteCRM/blob/master/modules/ModuleBuilder/views/view.modulefields.php#L109 It looks like this was resolved in view.modulefield.php in previous versions. I've just adapted it to be used in this class. https://github.com/salesagility/SuiteCRM/blob/master/modules/ModuleBuilder/views/view.modulefield.php#L158 ## Description ## Motivation and Context Users on PHP 7.4+ with Warnings enabled are not shown a display error when creating a field in Studio/ModuleBuilder. ## How To Test This 1. Install version 7.11.20 on PHP 7.4 with default error reporting (WARNINGS enabled) 2. Confirm that user can create fields successfully without errors on screens. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Final checklist - [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/). - [ ] My change requires a change to the documentation. - [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.

alessandro · 8 October 2021 13:54

Hi,
now it works adding class creation if not exists as in line 158.
Thanks.

samus-aran · 8 October 2021 13:58

Thanks @alessandro

You had confused me there. Are you confirming that adding the following code to LINE 89 in modules/ModuleBuilder/views/view.modulefields.php has resolved your issue?

            global $dictionary;
        if (!isset($studioClass->mbvardefs) || is_null($studioClass->mbvardefs)) {
            $studioClass->mbvardefs = new stdClass();
        }

If it has then super. Can you also comment on the GitHub PR so that it helps the devs to merge it in Awesome work. Thanks for your participation.

zillion_dev · 8 October 2021 15:04

@samus-aran after adding your code on line 89 in modules/ModuleBuilder/views/view.modulefields.php.
warning has been removed but now I am getting this new database failure error.

samus-aran · 8 October 2021 15:06

Ok. So what does the database error say?

“Please refer to suitecrm.log for details”

pstevens · 10 October 2021 02:25

Hey Guys, not sure if it’s relevant here, but I had a similar kind of error in Studio when trying to add a relationship. I fixed it by re-building the JS files in Repair. It then allowed me to proceed with adding a relationship.

https://community.suitecrm.com/t/relationship-popup-not-working-in-studio-7-10-25/78900/3

CRMFox · 26 October 2021 10:10

I can confirm, that the change in view.modulefields.php is working

System:
suiteCRM 7.11.22
PHP 7.4.25
MySQL 5.7

when will we see this in the main branch?