We have the following choices in the report moule:
• Equal to
• Not Equal to
• Contains
• Starts With
• Ends With
What I am trying to do is to add “Not Like” or ‘Does not Starts with’ in the options as I need to query all subjects that doesn’t match with a certain prefix?
I think that, since there is a PR for this we could also add some other missing operators that may be useful:
. Not Starts With
. Not Ends With
. Is Null (only for AOR Reports)
. Is NOT Null
One way or the other, I agree these additions would be good. Amariussi, your suggestion could also be nice to have there on GitHub, maybe you can ask the developer that proposed this to add those other options.
@Pgr: following your suggestio I proposed it to the developer.
In case he doesn’t do it how can I add the missing code myself in his PR?
Adding a NOT Operator would be even nicer but I presume it is also more complex so, for the time being I would suggest just the extra (and possibly other) operators that I suggested.
Github let’s you add commits to an existing PR, nothing is needed to update the PR, the commits are automatically considered as part of it as long as they are made on the same branch.
But since the source repository isn’t public (I assume) you would have to make a Pull Request on that user’s repo, here:
Then he would be notified and hopefully merge your code into his branch (thereby making it part of the same existing PR).
Another alternative is to pull his code from that branch into your local Git set-up, do your changes, make a new PR to SalesAgility, and explain that your PR supersedes the other one.