Problem with filters and maps

GianlucaSedoc · 11 March 2020 17:01

i’ve found a way to fix it. in the map contrller, on line 951 i’ve put this control

$filter = "";
		if($_SESSION['export_where'] && empty($_REQUEST['uid']))
			$filter = " AND ".$_SESSION['export_where'];
		
		$query = $query. str_replace ('where','',$filter);

so if there aren’t uid sent, i check the export_where in session. and works

pgr · 11 March 2020 17:04

Cool! Is this fix good enough that we can put it into the main code?

GianlucaSedoc · 12 March 2020 07:58

Actually i’ve tested only for the filter applied on account. Because is the only module that my client needs to geolocalize. For the caccounts works

pgr · 12 March 2020 09:52

Let me check with you exactly where that code should be inserted - is it after this line here?

github.com

salesagility/SuiteCRM/blob/master/modules/jjwg_Maps/controller.php#L962


        " AND " .
        "(" . $this->display_object->table_name . "_cstm.jjwg_maps_geocode_status_c = 'OK')";
$query = $this->display_object->create_new_list_query('', $where_conds, array(), array(), 0, '', false, $this->display_object, false);
if ($display_module == 'Contacts') { // Contacts - Account Name
    $query = str_replace(' FROM contacts ', ' ,accounts.name AS account_name, accounts.id AS account_id  FROM contacts  ', $query);
    $query = str_replace(' FROM contacts ', ' FROM contacts LEFT JOIN accounts_contacts ON contacts.id=accounts_contacts.contact_id and accounts_contacts.deleted = 0 LEFT JOIN accounts ON accounts_contacts.account_id=accounts.id AND accounts.deleted=0 ', $query);
} elseif ($display_module == 'Opportunities') { // Opps - Account Name
    $query = str_replace(' FROM opportunities ', ' ,accounts.name AS account_name, accounts.id AS account_id  FROM opportunities  ', $query);
    $query = str_replace(' FROM opportunities ', ' FROM opportunities LEFT JOIN accounts_opportunities ON opportunities.id=accounts_opportunities.opportunity_id and accounts_opportunities.deleted = 0 LEFT JOIN accounts ON accounts_opportunities.account_id=accounts.id AND accounts.deleted=0 ', $query);
}
//var_dump($query);


$display_result = $this->bean->db->limitQuery($query, 0, $this->settings['map_markers_limit']);
$this->bean->map_markers = array();
while ($display = $this->bean->db->fetchByAssoc($display_result)) {
    if (!empty($search_array['where'])) { // Select all records (advanced search) with where clause
        if (in_array($display['id'], $records)) {
            $this->bean->map_markers[] = $this->getMarkerData($display_module, $display, false, $mod_strings_display);
        }
    } elseif (!empty($_REQUEST['uid'])) { // Several records selected or this page selected
        if (in_array($display['id'], $records)) {

EDITED for clarity, to match the line indicated in the reply below

GianlucaSedoc · 12 March 2020 10:07

replace the var_dump($query) with my code. Remember, i’m using an old version of the crm.

pgr · 13 March 2020 11:06

Can you please open an issue with this on Github, and propose the solution?

acatt · 10 February 2022 22:29

I had this same problem with version 7.11.22
GianlucaSedoc’s solution worked for me.
I opened a Github issue: https://github.com/salesagility/SuiteCRM/issues/9504