I’m afraid I never tried that code.
As general advice, I think it’s ok to add logic hooks in modules that don’t have them, and reusing code from other modules is a good way to start, although it needs to be checked in detail to see if everything applies in the new module, and to change whatever needs to be adapted.
Logic hooks do require a QR&R to be made active, although subsequent changes to the hook’s code probably won’t require anything, they should be immediately effective (unless some fancier caching is interfering).