Helo everybody, this is my first post!
A php fatal error (resulting in a blank page) occurs while editing pdf templates if you have a directory inside modules/AOS_PDF_Templates/samples
For example the svn directory…
See attached file for an idea:
Have a nice day
Hi simoneosy,
can you please bit elaborate your question, that we can able to figure oue what actualy error is.
if possible, what fatal error you are getting, post it.
thanks.
Hi jaydeep,
this is the fatal error i got:
[04-Sep-2014 08:02:21 UTC] PHP Fatal error: require_once(): Failed opening required 'modules/AOS_PDF_Templates/samples/.svn' (include_path='/path/to/SuiteCRM711:/path/to/SuiteCRM711/include/HTMLPurifier/standalone:/path/to/SuiteCRM711/include/..:.:/usr/share/php:/usr/share/pear') in /path/to/SuiteCRM711/modules/AOS_PDF_Templates/views/view.edit.php on line 27The problem is that a check to not require a directory, if present, is not implemented, thus resulting in a php fatal error.
I don’t know wheter someone would desire to create a directory inside that path but the typical case are the automatically create subversion directories.
hi,
what is there in the .svn file.
is that file related to view.edit.php file. check it out.
beceause u didnot attach the file that u have mentioned.
Hi,
the .svn is not a file is a directory. It is automatically created from the versioning system subversion in every versioned directory.
The problem is not the .svn directory but a missing check in the code of the view.edit.php file to not try to pass a directory as the argument for the php require call.
The attached view.edit.php file contains a patch i wrote to correct this problem, if you are a developer and make a diff with the original file (modules/AOS_PDF_Templates/views/view.edit.php) i’m sure the problem will be clearer.
first of all where is your attach file dude. i didnot find. anyway
AS PER THE line no. 27 it will reading all the files whats there in the sample directory.
but svn directory is not there. so unexpectedly it is encountering the error.
beaceause the code is written to open and reading the file not to open directory.
i don’t know whether its a correct way or not to solve the issue. just move that svn directory temporary and check whether it is working or not.
First of all, i write this post only to try to help you and your code
Second, sorry for tha missing attached file, probably there were a problem uploading it and i didn’t notice that
Third, you simply cannot move the subversion directories otherwise you will go into trouble with that versioning system.
Now i see: uploading a file in this forum is not working without giving any error, with my chrome Version 37.0.2062.94 (64-bit) - Kubuntu 12.04
So here the complete code, you can see my patch inside the OPENSYMBOLMOD comments:
<?php
if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
require_once('include/MVC/View/views/view.edit.php');
class AOS_PDF_TemplatesViewEdit extends ViewEdit {
function AOS_PDF_TemplatesViewEdit(){
parent::ViewEdit();
}
function display(){
$this->setFields();
parent::display();
$this->displayTMCE();
}
function setFields(){
global $app_list_strings, $mod_strings, $beanList;
//Loading Sample Files
$json = getJSONobj();
$samples = array();
if ($handle = opendir('modules/AOS_PDF_Templates/samples')) {
$sample_options_array[] = ' ';
while (false !== ($file = readdir($handle))) {
//OPENSYMBOLMOD simo - too confident to not exclude directories...think about .svn for example
if ( !is_file($file) ) {
continue;
}
//OPENSYMBOLMOD simo
if($value = ltrim(rtrim($file,'.php'),'smpl_')){
require_once('modules/AOS_PDF_Templates/samples/'.$file);
$file = rtrim($file,'.php');
$file = new $file();
$fileArray =
array(
$file->getType(),
$file->getBody(),
$file->getHeader(),
$file->getFooter()
);
$fileArray = $json->encode($fileArray);
$value = $mod_strings['LBL_'.strtoupper($value)];
$sample_options_array[$fileArray] = $value;
}
}
$samples = get_select_options($sample_options_array,'');
closedir($handle);
}
$this->ss->assign('CUSTOM_SAMPLE','<select id="sample" name="sample" onchange="insertSample(this.options[this.selectedIndex].value)">'.
$samples.
'</select>');
$insert_fields_js ="<script>var moduleOptions = {\n";
$insert_fields_js2 ="<script>var regularOptions = {\n";
$modules = $app_list_strings['pdf_template_type_dom'];
foreach($modules as $moduleName => $value) {
$options_array = array(''=>'');
$mod_options_array = array();
//Getting Fields
if(!$beanList[$moduleName]){
continue;
}
$module = new $beanList[$moduleName]();
foreach($module->field_defs as $name => $arr){
if(!((isset($arr['dbType']) && strtolower($arr['dbType']) == 'id') || (isset($arr['type']) && $arr['type'] == 'id') || (isset($arr['type']) && $arr['type'] == 'link'))){
if(!isset($arr['reportable']) || $arr['reportable']){
$options_array['$'.$module->table_name.'_'.$name] = translate($arr['vname'],$module->module_dir);
}
}
} //End loop.
$options = json_encode($options_array);
$mod_options_array[$module->module_dir] = translate('LBL_MODULE_NAME',$module->module_dir);
$insert_fields_js2 .="'$moduleName':$options,\n";
$firstOptions = $options;
$fmod_options_array = array();
foreach($module->field_defs as $module_name => $module_arr){
if(isset($module_arr['type']) && $module_arr['type'] == 'relate' && isset($module_arr['source']) && $module_arr['source'] == 'non-db'){
$options_array = array(''=>'');
if(isset($module_arr['module']) && $module_arr['module'] != '' && $module_arr['module'] != 'EmailAddress'){
$relate_module_name = $beanList[$module_arr['module']];
$relate_module = new $relate_module_name();
foreach($relate_module->field_defs as $relate_name => $relate_arr){
if(!((isset($relate_arr['dbType']) && strtolower($relate_arr['dbType']) == 'id') || $relate_arr['type'] == 'id' || $relate_arr['type'] == 'link')){
if((!isset($relate_arr['reportable']) || $relate_arr['reportable']) && isset($relate_arr['vname'])){
$options_array['$'.$module_arr['name'].'_'.$relate_name] = translate($relate_arr['vname'],$relate_module->module_dir);
}
}
} //End loop.
$options = json_encode($options_array);
if($module_arr['vname'] != 'LBL_DELETED'){
$options_array['$'.$module->table_name.'_'.$name] = translate($module_arr['vname'],$module->module_dir);
$fmod_options_array[$module_arr['vname']] = translate($relate_module->module_dir).' : '.translate($module_arr['vname'],$module->module_dir);
}
$test = $module_arr['vname'];
$insert_fields_js2 .="'$test':$options,\n";
}
}
}
//LINE ITEMS CODE!
if(isset($module->lineItems) && $module->lineItems){
//add group fields
$options_array = array(''=>'');
$group_quote = new AOS_Line_Item_Groups();
foreach($group_quote->field_defs as $line_name => $line_arr){
if(!((isset($line_arr['dbType']) && strtolower($line_arr['dbType']) == 'id') || $line_arr['type'] == 'id' || $line_arr['type'] == 'link')){
if((!isset($line_arr['reportable']) || $line_arr['reportable']) ){//&& $line_arr['vname'] != 'LBL_NAME'
$options_array['$'.$group_quote->table_name.'_'.$line_name] = translate($line_arr['vname'],$group_quote->module_dir);
}
}
}
$options = json_encode($options_array);
$line_module_name = $beanList['AOS_Line_Item_Groups'];
$fmod_options_array[$line_module_name] = translate('LBL_LINE_ITEMS','AOS_Quotes').' : '.translate('LBL_MODULE_NAME','AOS_Line_Item_Groups');
$insert_fields_js2 .="'$line_module_name':$options,\n";
//PRODUCTS
$options_array = array(''=>'');
$product_quote = new AOS_Products_Quotes();
foreach($product_quote->field_defs as $line_name => $line_arr){
if(!((isset($line_arr['dbType']) && strtolower($line_arr['dbType']) == 'id') || $line_arr['type'] == 'id' || $line_arr['type'] == 'link')){
if(!isset($line_arr['reportable']) || $line_arr['reportable']){
$options_array['$'.$product_quote->table_name.'_'.$line_name] = translate($line_arr['vname'],$product_quote->module_dir);
}
}
}
$product_quote = new AOS_Products();
foreach($product_quote->field_defs as $line_name => $line_arr){
if(!((isset($line_arr['dbType']) && strtolower($line_arr['dbType']) == 'id') || $line_arr['type'] == 'id' || $line_arr['type'] == 'link')){
if((!isset($line_arr['reportable']) || $line_arr['reportable']) && $line_arr['vname'] != 'LBL_NAME'){
$options_array['$'.$product_quote->table_name.'_'.$line_name] = translate($line_arr['vname'],$product_quote->module_dir);
}
}
}
$options = json_encode($options_array);
$line_module_name = $beanList['AOS_Products_Quotes'];
$fmod_options_array[$line_module_name] = translate('LBL_LINE_ITEMS','AOS_Quotes').' : '.translate('LBL_MODULE_NAME','AOS_Products');
$insert_fields_js2 .="'$line_module_name':$options,\n";
//Services
$options_array = array(''=>'');
$options_array['$aos_services_quotes_name'] = translate('LBL_SERVICE_NAME','AOS_Quotes');
$options_array['$aos_services_quotes_number'] = translate('LBL_LIST_NUM','AOS_Products_Quotes');
$options_array['$aos_services_quotes_service_list_price'] = translate('LBL_SERVICE_LIST_PRICE','AOS_Quotes');
$options_array['$aos_services_quotes_service_discount'] = translate('LBL_SERVICE_DISCOUNT','AOS_Quotes');
$options_array['$aos_services_quotes_service_unit_price'] = translate('LBL_SERVICE_PRICE','AOS_Quotes');
$options_array['$aos_services_quotes_vat_amt'] = translate('LBL_VAT_AMT','AOS_Quotes');
$options_array['$aos_services_quotes_vat'] = translate('LBL_VAT','AOS_Quotes');
$options_array['$aos_services_quotes_service_total_price'] = translate('LBL_TOTAL_PRICE','AOS_Quotes');
$options = json_encode($options_array);
$s_line_module_name = 'AOS_Service_Quotes';
$fmod_options_array[$s_line_module_name] = translate('LBL_LINE_ITEMS','AOS_Quotes').' : '.translate('LBL_SERVICE_MODULE_NAME','AOS_Products_Quotes');
$insert_fields_js2 .="'$s_line_module_name':$options,\n";
$options_array = array(''=>'');
$currencies = new currency();
foreach($currencies->field_defs as $name => $arr){
if(!((isset($arr['dbType']) && strtolower($arr['dbType']) == 'id') || $arr['type'] == 'id' || $arr['type'] == 'link' || $arr['type'] == 'bool' || $arr['type'] == 'datetime' || (isset($arr['link_type']) && $arr['link_type'] == 'relationship_info'))){
if(isset($arr['vname']) && $arr['vname'] != 'LBL_DELETED' && $arr['vname'] != 'LBL_CURRENCIES_HASH' && $arr['vname'] != 'LBL_LIST_ACCEPT_STATUS' && $arr['vname'] != 'LBL_AUTHENTICATE_ID' && $arr['vname'] != 'LBL_MODIFIED_BY' && $arr['name'] != 'created_by_name'){
$options_array['$currencies_'.$name] = translate($arr['vname'],'Currencies');
}
}
}
$options = json_encode($options_array);
$line_module_name = $beanList['Currencies'];
$fmod_options_array[$line_module_name] = translate('LBL_MODULE_NAME','Currencies').' : '.translate('LBL_MODULE_NAME','Currencies');
$insert_fields_js2 .="'$line_module_name':$options,\n";
}
array_multisort($fmod_options_array, SORT_ASC, $fmod_options_array);
$mod_options_array = array_merge($mod_options_array, $fmod_options_array);
$module_options = json_encode($mod_options_array);
$insert_fields_js .="'$moduleName':$module_options,\n";
$moduleOptions[$moduleName] = array("module" => $module_options,"option" => $firstOptions);
} //End loop.
//Sets options to original options on load.
$insert_fields_js .= "} ;</script>";
$insert_fields_js2 .= "} ;</script>";
//echo $this->bean->type;
if($this->bean->type=='') {
$type = key($app_list_strings['pdf_template_type_dom']);
}else{
$type = $this->bean->type;
}
//Start of insert_fields
$insert_fields = '';
$insert_fields .= <<<HTML
$insert_fields_js
$insert_fields_js2
<select name='module_name' id='module_name' tabindex="50" onchange="populateVariables(this.options[this.selectedIndex].value);">
</select>
<select name='variable_name' id='variable_name' tabindex="50" onchange="showVariable(this.options[this.selectedIndex].value);">
</select>
<input type="text" size="30" tabindex="60" name="variable_text" id="variable_text" />
<input type='button' tabindex="70" onclick='insert_variable(document.EditView.variable_text.value);' class='button' value='${mod_strings['LBL_BUTTON_INSERT']}'>
<script type="text/javascript">
populateModuleVariables("$type");
</script>
HTML;
$this->ss->assign('INSERT_FIELDS',$insert_fields);
}
function displayTMCE(){
require_once("include/SugarTinyMCE.php");
global $locale;
$tiny = new SugarTinyMCE();
$tinyMCE = $tiny->getConfig();
$js =<<<JS
<script language="javascript" type="text/javascript">
$tinyMCE
var df = '{$locale->getPrecedentPreference('default_date_format')}';
tinyMCE.init({
theme : "advanced",
theme_advanced_toolbar_align : "left",
mode: "exact",
elements : "description",
theme_advanced_toolbar_location : "top",
theme_advanced_buttons1: "code,help,separator,bold,italic,underline,strikethrough,separator,justifyleft,justifycenter,justifyright,justifyfull,separator,forecolor,backcolor,separator,styleprops,styleselect,formatselect,fontselect,fontsizeselect",
theme_advanced_buttons2: "cut,copy,paste,pastetext,pasteword,selectall,separator,search,replace,separator,bullist,numlist,separator,outdent,indent,separator,ltr,rtl,separator,undo,redo,separator, link,unlink,anchor,image,separator,sub,sup,separator,charmap,visualaid",
theme_advanced_buttons3: "tablecontrols,separator,advhr,hr,removeformat,separator,insertdate,pagebreak",
theme_advanced_fonts:"Andale Mono=andale mono,times;Arial=arial,helvetica,sans-serif;Arial Black=arial black,avant garde;Book Antiqua=book antiqua,palatino;Comic Sans MS=comic sans ms,sans-serif;Courier New=courier new,courier;Georgia=georgia,palatino;Helvetica=helvetica;Helvetica Neu=helveticaneue,sans-serif;Impact=impact,chicago;Symbol=symbol;Tahoma=tahoma,arial,helvetica,sans-serif;Terminal=terminal,monaco;Times New Roman=times new roman,times;Trebuchet MS=trebuchet ms,geneva;Verdana=verdana,geneva;Webdings=webdings;Wingdings=wingdings,zapf dingbats",
plugins : "advhr,insertdatetime,table,paste,searchreplace,directionality,style,pagebreak",
height:"500",
width: "100%",
inline_styles : true,
directionality : "ltr",
remove_redundant_brs : true,
entity_encoding: 'raw',
cleanup_on_startup : true,
strict_loading_mode : true,
convert_urls : false,
plugin_insertdate_dateFormat : '{DATE '+df+'}',
pagebreak_separator : "<pagebreak />",
extended_valid_elements : "textblock",
custom_elements: "textblock",
});
tinyMCE.init({
theme : "advanced",
theme_advanced_toolbar_align : "left",
mode: "exact",
elements : "pdfheader,pdffooter",
theme_advanced_toolbar_location : "top",
theme_advanced_buttons1: "code,separator,bold,italic,underline,strikethrough,separator,justifyleft,justifycenter,justifyright,justifyfull,separator,undo,redo,separator,forecolor,backcolor,separator,styleprops,styleselect,formatselect,fontselect,fontsizeselect,separator,insertdate",
theme_advanced_buttons2 : "",
theme_advanced_buttons3 : "",
theme_advanced_fonts:"Andale Mono=andale mono,times;Arial=arial,helvetica,sans-serif;Arial Black=arial black,avant garde;Book Antiqua=book antiqua,palatino;Comic Sans MS=comic sans ms,sans-serif;Courier New=courier new,courier;Georgia=georgia,palatino;Helvetica=helvetica;Helvetica Neu=helveticaneue,sans-serif;Impact=impact,chicago;Symbol=symbol;Tahoma=tahoma,arial,helvetica,sans-serif;Terminal=terminal,monaco;Times New Roman=times new roman,times;Trebuchet MS=trebuchet ms,geneva;Verdana=verdana,geneva;Webdings=webdings;Wingdings=wingdings,zapf dingbats",
plugins : "advhr,insertdatetime,table,paste,searchreplace,directionality,style",
width: "100%",
inline_styles : true,
directionality : "ltr",
entity_encoding: 'raw',
cleanup_on_startup : true,
strict_loading_mode : true,
convert_urls : false,
remove_redundant_brs : true,
plugin_insertdate_dateFormat : '{DATE '+df+'}',
extended_valid_elements : "textblock",
custom_elements: "textblock",
});
</script>
JS;
echo $js;
}
}
?>
Hi simoneosy,
First of all, i m here to help others who ever faceing problem. This is not my code or neither i am a member of suitecrm group. I am a developer like every other else . i am just trying to help only.
About the upload / attachment it works. but in ur case dont know y it is not working.
Your solution ,
REMOVE YOUR CODE , TRY THIS,
Check [// brgin code //end coe]
while (false !== ($file = readdir($handle))) {
//OPENSYMBOLMOD simo - too confident to not exclude directories...think about .svn for example
//NO NEED
// if ( !is_file($file) ) {
// continue;
// }
//OPENSYMBOLMOD simo
if($value = ltrim(rtrim($file,'.php'),'smpl_')){
//make changes here
//Begin code
if ($value == ".svn")
continue;
//End code
require_once('modules/AOS_PDF_Templates/samples/'.$file);
$file = rtrim($file,'.php');
$file = new $file();
$fileArray =
array(
$file->getType(),
$file->getBody(),
$file->getHeader(),
$file->getFooter()
);
$fileArray = $json->encode($fileArray);
$value = $mod_strings['LBL_'.strtoupper($value)];
$sample_options_array[$fileArray] = $value;
}
}Thanks for the advice but i’m good with my code, it’s a more generalistic solution and it is perfectly working: is_file() returns true only if the argument passed is a regular file (directories are not) and a regular file is what your code wants.
What if someone creates a directory inside that path for whatever reason that is not called ‘.svn’?
By the way what i would like to see it’s a solution for this problem in the next release of suiteCRM, wheter it wiil be mine or yours it’s up to you.
Remember that subversion is being widely replaced by git, but it is still used
Yah You are correct.
This bug has to solved by suitecrm community.
but the thing is that, is_file is correct. but what i have given solution as per the error. beceause i also new to this error.
By the way, thanks for the info about subversion .
:cheer:
You’re welcome 
Just a question: isn’t this the right place to communicate with the suiteCRM community developers, is it? :dry:
Edit: just found a github repo for suiteCRM 7.1.3, i will try to make a pull request there