Audited field not showing in the change log

rsp · 26 November 2024 17:31

We have a relate field in the module and audit is set to true in the studio. But, it is not displaying changes in the log.

If I click on ‘View Change Log’ option and check pop-up screen, the field name shows in the ‘Fields audited in this module’ section.

What is issue? Does anyone know the solution/workaround for this?

rsp · 26 November 2024 20:06

Looks like if you edit field from the detail view using inline edit option. It does not get log into change log.

But, if you update field value from the edit view then it will get log into change log.

Could someone please check in their instance and confirm it?

rsp · 27 November 2024 19:39

Anyone knows it? It is bug?

Harshad · 28 November 2024 06:41

Hi, can you please check if the log data is present in the corresponding db table. You would find the table name something like {MODULENAME}_audit.

Edit: It looks audit log for relate fields doesn’t work when the fields are edited inline. Old and new values not seen different when audit logs data is fetched. So the audit data is absent because of this. I am investigating the issue. I am not sure but there could be an issue in include/InlineEditing/InlineEditing.php file.

Harshad · 28 November 2024 16:42

I made the following change in include/InlineEditing/InlineEditing.php. This helped me to have audit logs for my related fields when edited inline on detail view page. It requires thorough testing for this solution to be used in production.

	$rel_bean=BeanFactory::getBean($bean->field_defs[$field]['module'], $value);
	$rname=$bean->field_defs[$field]['rname'];
	$bean->$field=$rel_bean->$rname;

Code changes look something like

rsp · 2 December 2024 15:24

Thank you for reply, this is code file and I think it starts at line 155. I’m using the SuiteCRM 7.13.x version.

github.com

salesagility/SuiteCRM/blob/hotfix-7.13.x/include/InlineEditing/InlineEditing.php#L155


      
          }
          
          $contents = $sfh->displaySmarty('fields', $vardef, $view, $displayParams);
          
          // Remove all the copyright comments
          $contents = preg_replace('/\{\*[^\}]*?\*\}/', '', $contents);
          // remove extra wrong javascript which breaks auto complete on flexi relationship parent fields
          $contents = preg_replace("/<script language=\"javascript\">if\(typeof sqs_objects == \'undefined\'\){var sqs_objects = new Array;}sqs_objects\[\'EditView_parent_name\'\].*?<\/script>/", "", $contents);
          
          
          if ($view == 'EditView' && ($vardef['type'] == 'relate' || $vardef['type'] == 'parent')) {
              $contents = str_replace('"' . $vardef['id_name'] . '"', '{/literal}"{$fields.' . $vardef['name'] . '.id_name}"{literal}', $contents);
              $contents = str_replace('"' . $vardef['name'] . '"', '{/literal}"{$fields.' . $vardef['name'] . '.name}"{literal}', $contents);
              // regex below fixes button javascript for flexi relationship
              if ($vardef['type'] == 'parent') {
                  $contents = str_replace("onclick='open_popup(document.{\$form_name}.parent_type.value, 600, 400, \"\", true, false, {literal}{\"call_back_function\":\"set_return\",\"form_name\":\"EditView\",\"field_to_name_array\":{\"id\":{/literal}\"{\$fields.parent_name.id_name}", "onclick='open_popup(document.{\$form_name}.parent_type.value, 600, 400, \"\", true, false, {literal}{\"call_back_function\":\"set_return\",\"form_name\":\"EditView\",\"field_to_name_array\":{\"id\":{/literal}\"parent_id", $contents);
              }
          }
          
          // hack to disable one of the js calls in this control
          if (isset($vardef['function']) && ($vardef['function'] == 'getCurrencyDropDown' || $vardef['function']['name'] == 'getCurrencyDropDown')) {

sorry, I did not find elseif loop that you mentioned in the above picture.

What am I missing here?

Harshad · 2 December 2024 15:36

Please search saveField method at line 327. elseIf is at line no. 342. Image shows the line nos.

rsp · 2 December 2024 15:38

Thank you so much I found that code. In dev, it is logging that change.

Edit: @Harshad could you please make PR and suggest this code change?